sigv2: Do not encode canonical sub-resource value #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not encode sub-resource value (such is uploadID) when building canonicalized request string.
harshavardhana
requested changes
Apr 1, 2017
| @@ -316,7 +316,7 @@ func writeCanonicalizedResource(buf *bytes.Buffer, req http.Request, isPreSign b | |||
| // Request parameters | |||
| if len(vv[0]) > 0 { | |||
| buf.WriteByte('=') | |||
| buf.WriteString(strings.Replace(url.QueryEscape(vv[0]), "+", "%20", -1)) | |||
There was a problem hiding this comment.
@vadmeste can we test this with ListObjects() with some UTF-8 files and see how it works.
There was a problem hiding this comment.
@vadmeste can we test this with ListObjects() with some UTF-8 files and see how it works.
- I already tested that case with more than 1000 objects which has unicode characters, and that to trigger 'next token' query params in web requests
- I also tested v2 tests function of minio-go with AWS S3
- I also tested manually many use cases
Besides, the change line affects only values of Resource parameters:
260 var resourceList = []string{
261 "acl",
262 "delete",
263 "location",
264 "logging",
265 "notification",
266 "partNumber",
267 "policy",
268 "requestPayment",
269 "torrent",
270 "uploadId",
271 "uploads",
272 "versionId",
273 "versioning",
274 "versions",
275 "website",
276 }
By the way, S3 spec is not clear about the behavior of this case.
How did I find the bug?
I made a manual change in minio-go to send uploadID="QsbxgdvySmWkYZ2X84hQPg==" instead of the one that it receives from AWS in list multipart uploads. In that case, AWS returns signature mismatch.
harshavardhana
approved these changes
Apr 1, 2017
harshavardhana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not encode sub-resource value (such is uploadID) when building
canonicalized request string.