Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export ListObjectV2 to core client #638

Merged
merged 1 commit into from
Apr 5, 2017
Merged

Export ListObjectV2 to core client #638

merged 1 commit into from
Apr 5, 2017

Conversation

nl5887
Copy link
Contributor

@nl5887 nl5887 commented Apr 4, 2017

  • needed for gateway

krishnasrinivas
krishnasrinivas reviewed Apr 4, 2017
View reviewed changes
api-s3-datatypes.go
@@ -42,7 +42,7 @@ type commonPrefix struct {
}

// listBucketResult container for listObjects V2 response.
type listBucketV2Result struct {
type ListBucketV2Result struct {
// A response can contain CommonPrefixes only if you have
// specified a delimiter.
CommonPrefixes []commonPrefix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CommonPrefixes's type commonPrefix is not exported. Will Go complain when:

prefixes := result.CommonPrefixes

because the type commonPrefix is not exported

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nl5887 do you think this is a problem ?

Copy link
Contributor Author

@nl5887 nl5887 Apr 5, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a problem. Users won't declare commonPrefix themselves (as they could do with ListBucketV2Result) and Go won't complain about:

prefixes := result.CommonPrefixes

@krishnasrinivas krishnasrinivas mentioned this pull request Apr 4, 2017
Closed
@harshavardhana
Copy link
Member

ping @nl5887

@harshavardhana harshavardhana merged commit bd69921 into minio:master Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnasrinivas krishnasrinivas krishnasrinivas left review comments

@harshavardhana harshavardhana harshavardhana left review comments

@vadmeste vadmeste vadmeste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nl5887 @harshavardhana @vadmeste @krishnasrinivas