Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Do not need Expect header. #640

Merged
merged 1 commit into from
Apr 5, 2017

Conversation

harshavardhana
Copy link
Member

Expect header is not support and implemented by GCS
and some S3 endpoints. Remove it as it doesn't add
much purpose.

Expect header is not support and implemented by GCS
and some S3 endpoints. Remove it as it doesn't add
much purpose.
@vadmeste
Copy link
Member

vadmeste commented Apr 5, 2017

Hard to see the benefit in practice, let's merge this and let's the community decide.

@krishnasrinivas
Copy link
Contributor

what was the reason we brought in Expect header support on client? One obvious advantage is we dont read from the stream if the auth fails. But there was something else too?

@harshavardhana
Copy link
Member Author

That was the only thing.

@harshavardhana
Copy link
Member Author

harshavardhana commented Apr 5, 2017

But our server doesn't do true expect continue I think. The control is inside Go http server. By the time request comes it already said yes to the client.

@harshavardhana harshavardhana merged commit fdf3754 into minio:master Apr 5, 2017
@harshavardhana harshavardhana deleted the remove-expect branch April 5, 2017 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants