Added length to the return values #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a documentation change
vadmeste
reviewed
Apr 17, 2017
docs/API.md
Outdated
| @@ -530,7 +530,7 @@ if err != nil { | |||
| ``` | |||
|
|
|||
| <a name="FPutObject"></a> | |||
| ### FPutObject(bucketName, objectName, filePath, contentType string) error | |||
| ### FPutObject(bucketName, objectName, filePath, contentType string) (length int, err error) | |||
There was a problem hiding this comment.
Actually it is int64 not int.
Can you correct it before merging it ? Thanks anyway.
|
Will do! Probably in about an hour (I'm running a load test)
…--dave
On 17/04/17 09:32 AM, Anis Elleuch wrote:
***@***.**** commented on this pull request.
------------------------------------------------------------------------
In docs/API.md
<#652 (comment)>:
> @@ -530,7 +530,7 @@ if err != nil {
```
<a name="FPutObject"></a>
-### FPutObject(bucketName, objectName, filePath, contentType string) error
+### FPutObject(bucketName, objectName, filePath, contentType string) (length int, err error)
Actually it is int64 not int.
Can you correct it before merging it ? Thanks anyway.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#652 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAiJkWOjVRO44_g-Eo8xSz9iIZIPJb1Lks5rw2ntgaJpZM4M_JOS>.
--
David Collier-Brown, | Always do right. This will gratify
System Programmer and Author | some people and astonish the rest
[email protected] | -- Mark Twain
|
|
OK, that looks more plausible |
|
Thanks @davecb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a documentation change