api: Single putObject can use temporary file always. #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code simplification also addresses bugs which can arise from issues like minio#702 where error handling in multiple conditions is cryptic. Benefit of this fix is also that we are not going to buffer memory if there are lot of copy operations, since our min-part size has increased to 64MB using bytes buffer may cause each file copy to use 128MB worth of memory due to `bytes.Buffer` growth strategy used in go standard library. Incidentally this change fixes minio#702
krisis
reviewed
Jun 12, 2017
|
The error occurs only when you restrict the bucket with some I AM policy . I have creds for that for you to verify if needed. @krisis |
vadmeste
approved these changes
Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code simplification also addresses bugs which
can arise from issues like #702 where error handling
in multiple conditions is cryptic.
Benefit of this fix is also that we are not going
to buffer memory if there are lot of copy operations,
since our min-part size has increased to 64MB using
bytes buffer may cause each file copy to use 128MB
worth of memory due to
bytes.Buffergrowth strategyused in go standard library.
Incidentally this change fixes #702