api: Update progress bar concurrently. #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we had a bug where progress bar was only updated after the upload has been completed. With streaming signature we don't need to do that. This PR fixes this behavior. This PR also removes a double progress bar jump in case of fallback buffer based multipart upload.
krisis
approved these changes
Jun 30, 2017
|
Good change, this also fix this issue minio/mc#2169 |
vadmeste
reviewed
Jun 30, 2017
| @@ -113,13 +113,6 @@ func (c Client) putObjectMultipartNoStream(bucketName, objectName string, reader | |||
| // Save successfully uploaded part metadata. | |||
| partsInfo[partNumber] = objPart | |||
|
|
|||
| // Update the progress reader for the skipped part. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we had a bug where progress bar
was only updated after the upload has been
completed. With streaming signature we
don't need to do that.
This PR fixes this behavior. This PR also
removes a double progress bar jump
in case of fallback buffer based multipart upload.