Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix all documentation mistakes and examples #760

Merged
merged 1 commit into from
Jul 15, 2017
Merged

docs: Fix all documentation mistakes and examples #760

merged 1 commit into from
Jul 15, 2017

Conversation

harshavardhana
Copy link
Member

No description provided.

@harshavardhana harshavardhana force-pushed the fix-docs branch 7 times, most recently from bd40d02 to f6de1be Compare July 14, 2017 10:17
@harshavardhana harshavardhana changed the title docs: Fix NewDestinationInfo documentation. docs: Fix all documentation mistakes Jul 14, 2017
@harshavardhana harshavardhana changed the title docs: Fix all documentation mistakes docs: Fix all documentation mistakes and examples Jul 14, 2017
krisis
krisis approved these changes Jul 14, 2017
View reviewed changes
Copy link
Member

@krisis krisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change! Adding building of example programs in travis-ci would avoid these mistakes in future.

@deekoder deekoder requested a review from nitisht July 14, 2017 21:42
@nitisht
Copy link
Contributor

nitisht commented Jul 15, 2017

LGTM. Why not enable running functional tests as well?

@harshavardhana
Copy link
Member Author

LGTM. Why not enable running functional tests as well?

Not part of this PR @nitisht once this is done #742 we can enable it.

@harshavardhana
Copy link
Member Author

Not part of this PR @nitisht once this is done #742 we can enable it.

Actually decided to enable it anyways as you suggested.

@deekoder deekoder merged commit 6fa5462 into minio:master Jul 15, 2017
@harshavardhana harshavardhana deleted the fix-docs branch July 15, 2017 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitisht nitisht nitisht approved these changes

@krisis krisis krisis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshavardhana @nitisht @krisis @deekoder