api: PutObjectSignV2 should support uploading 0byte objects. #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmeste
requested changes
Jul 14, 2017
harshavardhana
force-pushed
the
v2-sign
branch
3 times, most recently
from
2a174da to
d7a13a5
Compare
krisis
requested changes
Jul 15, 2017
api-put-object-multipart.go
Outdated
| @@ -141,7 +141,7 @@ func (c Client) putObjectMultipartNoStream(bucketName, objectName string, reader | |||
| } | |||
|
|
|||
| // Verify if we uploaded all the data. | |||
| if size > 0 { | |||
| if size >= 0 { | |||
There was a problem hiding this comment.
putObjectNoChecksum is called when size is zero. So, this check is not needed.
There was a problem hiding this comment.
The reason this is done is multipart should also work for size == 0 independent of its upper layer usage.
api-put-object-common.go
Outdated
| // object size is '0' set default parts. | ||
| if objectSize == 0 { | ||
| return 1, 0, 0, nil | ||
| } |
There was a problem hiding this comment.
putObjectNoChecksum is called when size is zero. So, this check is not needed.
There was a problem hiding this comment.
This code should work accordingly regardless of how its stitched together
| @@ -3596,6 +3596,64 @@ func testUserMetadataCopyingV2() { | |||
| testUserMetadataCopyingWrapper(c) | |||
| } | |||
|
|
|||
| // Test put object with 0 byte object. | |||
There was a problem hiding this comment.
We should have a test for V4 too.
There was a problem hiding this comment.
V4 we already have PutObjectStreaming uploads a 0byte file.
krisis
approved these changes
Jul 15, 2017
|
@vadmeste can you take a look PR is updated with unit test as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #761