-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in the readme #767
Conversation
@fetmar why do you suggest we change Println to Printf ? Is the output looking better in the latter? |
It's failing in travis but I'm not sure why since I didn't change anything but the readme. Fails here:
|
@deekoder Just because the original line there says %v, which is a formatting string. Actually, I like that better. I'll remove the formatting string altogether. :) |
On second thought... Println(minioClient)
Printf("%+v\n", minioClient)
Printf("%#v\n", minioClient)
I prefer the last option. It's the prettiest of the prints that's a part of go's standard library. 🌹 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Okay to use Printf() to print the variables in the Go fashion.
// cc @deekoder we can take this in if you don't have further questions? |
// cc @deekoder if you don't have any further questions we can take this in. |
Sorry for the delay. Merging now. |
Changed Println with formatting to a Printf