fix: Mutating variables within go closures should be explicit. #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partSize, a variable on the stack, changes over the course of uploading multiple objects. This was being used in a function closure as a go-routine. The variables used in the closure depend on their values the time of evaluation providing inconsistent behavior. It is racy to depend on values of variables on stack at the end of function, when go-routines are executed. Fixes minio#784
harshavardhana
force-pushed
the
fix-racy-go-routine
branch
from
1180d48 to
f2773c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partSize, a variable on the stack, changes over the course of
uploading multiple objects. This was being used in a function
closure as a go-routine. The variables used in the closure
depend on their values the time of evaluation providing inconsistent
behavior. It is racy to depend on values of variables on stack
at the end of function, when go-routines are executed.
Fixes #784