Encryption headers should also be set during initMultipart #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
fix-headers
branch
from
ed39878 to
2021194
Compare
poornas
approved these changes
Feb 24, 2018
| @@ -527,6 +527,12 @@ func (c Client) ComposeObject(dst DestinationInfo, srcs []SourceInfo) error { | |||
| for k, v := range metaMap { | |||
| metaHeaders[k] = v | |||
| } | |||
|
|
|||
| // Add destination encryption headers | |||
| for k, v := range dst.encryption.getSSEHeaders(false) { | |||
There was a problem hiding this comment.
more readable to just use GetSSEHeaders().LGTM otherwise.
There was a problem hiding this comment.
We don't need to stick to requirements of a public function. Since this is an internal functionality it makes sense to use the internal function.
donatello
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reproduced while testing encryption features.