tests: Remove partial related tests #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmeste
force-pushed
the
remove_uneeded_tests
branch
from
22d11b5 to
1cfd074
Compare
testRemovePartiallyUploadedV2(), testListPartiallyUploaded() and testRemovePartiallyUploaded() were faking an error during uploading a large file hoping that it would leave some uploaded parts in the server, but actually minio-go already aborts multipart upload when an error occurs, so these tests are not useful. Detected when testing function tests using a NFS backend.
vadmeste
force-pushed
the
remove_uneeded_tests
branch
from
1cfd074 to
f667217
Compare
nitisht
approved these changes
Mar 23, 2018
krisis
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testRemovePartiallyUploadedV2(), testListPartiallyUploaded() and
testRemovePartiallyUploaded() were faking an error during uploading
a large file hoping that it would leave some uploaded parts in the server,
but actually minio-go already aborts multipart upload when an error occurs, so
these tests are not useful. Detected when testing function tests using a
NFS backend.