Fix #1372 - File download with encoded etag (#1373)

* Replaced etag with base64 encoded version to prevent slash character issue.
minio · Jan 20, 2025 · a8e1abb · a8e1abb
1 parent fd12add
commit a8e1abb
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/internal/client.ts b/src/internal/client.ts
@@ -1085,7 +1085,7 @@ export class TypedClient {
 
   /**
    * download object content to a file.
-   * This method will create a temp file named `${filename}.${etag}.part.minio` when downloading.
+   * This method will create a temp file named `${filename}.${base64(etag)}.part.minio` when downloading.
    *
    * @param bucketName - name of the bucket
    * @param objectName - name of the object
@@ -1112,7 +1112,8 @@ export class TypedClient {
     const downloadToTmpFile = async (): Promise<string> => {
       let partFileStream: stream.Writable
       const objStat = await this.statObject(bucketName, objectName, getOpts)
-      const partFile = `${filePath}.${objStat.etag}.part.minio`
+      const encodedEtag = Buffer.from(objStat.etag).toString('base64')
+      const partFile = `${filePath}.${encodedEtag}.part.minio`
 
       await fsp.mkdir(path.dirname(filePath), { recursive: true })