docs: example require #1136
Merged
docs: example require #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldy505
reviewed
May 5, 2023
Comment on lines
+23
to
+24
| var Minio = require('minio') | ||
| var Helpers = require('minio/dist/main/helpers') |
There was a problem hiding this comment.
Do you want to start modifying the variable instance with const rather than var?
There was a problem hiding this comment.
I don't think it matters in example. But it's better we perfer const in src code.
There was a problem hiding this comment.
I guess it would be a way to say that the library has been modernized. But it's okay if we're still using var on examples.
There was a problem hiding this comment.
prefer-const is previous disabled in eslint, I don't know how maintainers think. And I don't care much about code style in examples...
prakashsvmx
approved these changes
May 18, 2023
trim21
added a commit
to trim21/minio-js
that referenced
this pull request
May 24, 2023
Co-authored-by: Prakash Senthil Vel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.