Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate helpers.js/s3-endpoints.js/signing.js to TypeScript #1137

Merged
merged 57 commits into from
May 12, 2023
Merged

refactor: migrate helpers.js/s3-endpoints.js/signing.js to TypeScript #1137

merged 57 commits into from
May 12, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented May 5, 2023

No description provided.

@trim21 trim21 marked this pull request as ready for review May 5, 2023 07:58
@trim21 trim21 changed the title refactor: migrate helpers.js to TypeScript refactor: migrate helpers.js/s3-endpoints.js to TypeScript May 5, 2023
@trim21 trim21 mentioned this pull request May 5, 2023
Merged
@trim21 trim21 marked this pull request as draft May 5, 2023 11:26
@trim21 trim21 marked this pull request as ready for review May 5, 2023 12:31
aldy505
aldy505 reviewed May 5, 2023
View reviewed changes
src/helpers.ts Outdated Show resolved Hide resolved
src/internal/helper.ts Show resolved Hide resolved
@trim21
Copy link
Contributor Author

trim21 commented May 8, 2023

@prakashsvmx any plan on review this?

prakashsvmx
prakashsvmx reviewed May 9, 2023
View reviewed changes
src/helpers.ts Outdated Show resolved Hide resolved
prakashsvmx
prakashsvmx reviewed May 9, 2023
View reviewed changes
src/helpers.ts Outdated Show resolved Hide resolved
@trim21 trim21 requested a review from prakashsvmx May 9, 2023 10:51
github-advanced-security[bot]
github-advanced-security bot found potential problems May 9, 2023
View reviewed changes
src/helpers.ts

export { ENCRYPTION_TYPES, LEGAL_HOLD_STATUS, RETENTION_MODES, RETENTION_VALIDITY_UNITS } from './internal/type.ts'

export const DEFAULT_REGION = 'us-east-1'

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "us-east-1" is used as [authorization header](1).
@trim21
Copy link
Contributor Author

trim21 commented May 9, 2023 •
edited
Loading

tests on node 12.x are still required, make pr check status always pending

@prakashsvmx
Copy link
Member

we can stick to [12.x, 14.x, 16.x, 17.x, 18.x, 20.x] for testing.

@prakashsvmx
Copy link
Member

I am taking a look. 👍

prakashsvmx
prakashsvmx previously approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Tests running fine. 👍

@trim21 trim21 mentioned this pull request May 11, 2023
Merged
@harshavardhana harshavardhana merged commit 52e214e into minio:master May 12, 2023
@trim21 trim21 deleted the ts/helpers branch November 22, 2023 15:47
@VaniHaripriya VaniHaripriya mentioned this pull request Jun 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldy505 aldy505 aldy505 left review comments

@prakashsvmx prakashsvmx prakashsvmx approved these changes

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

@kannappanr kannappanr Awaiting requested review from kannappanr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trim21 @prakashsvmx @aldy505 @harshavardhana