refactor setBucketReplication and getBucketReplication
#1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trim21
reviewed
Jul 20, 2023
trim21
reviewed
Jul 20, 2023
|
thank you @trim21 . i will address the comments soon. |
prakashsvmx
force-pushed
the
ref-get-bucket-replication
branch
from
f00ec78 to
0375538
Compare
prakashsvmx
requested review from
trim21 and
kaankabalak
and removed request for
trim21
trim21
reviewed
Jul 21, 2023
|
only 1 problem |
prakashsvmx
force-pushed
the
ref-get-bucket-replication
branch
from
24b8f28 to
fa93a57
Compare
|
Lgtm |
kaankabalak
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor
setBucketReplicationandgetBucketReplication