translate minio-js docs to Chinese. #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnasrinivas
previously approved these changes
Nov 20, 2017
harshavardhana
requested review from
harshavardhana and
yihuaf
and removed request for
deekoder
|
Moved review from @deekoder due to unavailability. |
yihuaf
suggested changes
Nov 29, 2017
README_zh_CN.md
Outdated
| npm install --save minio | ||
| ``` | ||
|
|
||
| ## 下载源码安装 |
There was a problem hiding this comment.
Acturally I'm not.The code explains itself.Maybe I should change the comment back to English,for consistency.
There was a problem hiding this comment.
comments in code can be in english
docs/zh_CN/API.md
Outdated
|
|
||
| __示例__ | ||
|
|
||
| 单个对象的最大大小限制在5TB。putObject在对象大于5MiB时，自动使用multiple parts方式上传。这就当上传失败时，客户端只需要上传未成功的部分即可（类似断点上传）。上传的对象使用MD5SUM签名进行完整性验证。 |
docs/zh_CN/API.md
Outdated
| __示例__ | ||
|
|
||
|
|
||
| 单个对象的最大大小限制在5TB。fPutObject在对象大于5MiB时，自动使用multiple parts方式上传。这就当上传失败时，客户端只需要上传未成功的部分即可（类似断点上传）。上传的对象使用MD5SUM签名进行完整性验证。 |
There was a problem hiding this comment.
ditto
@yihuaf The original docs is ditto too,but I agree with you,it's a little redundant.I removed it in Chinese docs.
harshavardhana
previously approved these changes
Dec 13, 2017
krishnasrinivas
previously approved these changes
Dec 13, 2017
|
@harshavardhana this can be taken in right? |
|
@krishnasrinivas No. We need @yihuaf approval since hes is the key reviewer for this PR. |
|
@yihuaf ping. |
dingjs
dismissed stale reviews from krishnasrinivas and harshavardhana
via
ec169b1
yihuaf
approved these changes
Dec 19, 2017
krishnasrinivas
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translate minio-js docs to Chinese.