Support putObject to upload an empty file. #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
previously requested changes
Jan 3, 2018
shruthied
changed the title
|
@harshavardhana changed the title as mentioned. |
krishnasrinivas
previously approved these changes
Jan 3, 2018
|
@shruthied Travis and Appveyor failed. Please take a look at the failures and fix them. |
kaankabalak
approved these changes
Jan 4, 2018
|
@kannappanr fixed all the failures. Checks have been passed. |
src/main/object-uploader.js
Outdated
| else { | ||
| if (this.id === null) { | ||
| return | ||
| } |
There was a problem hiding this comment.
you don't need else statement here @shruthied because you have return statement at the end of if block above.
i.e you can do it like :
if (this.emptyStream) {
....
return
}
if (this.id == null) {
return
}
There was a problem hiding this comment.
removed the else statement as mentioned @krishnasrinivas
krishnasrinivas
approved these changes
Jan 4, 2018
kannappanr
changed the title
harshavardhana
dismissed
their stale review
LGTM, dismissing review not needed
dingjs
pushed a commit
to dingjs/minio-js
that referenced
this pull request
Jan 7, 2018
Support putObject to upload an empty file. Fixes minio#657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #657