makeBucket should use the requested region for signing #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kannappanr
reviewed
Mar 6, 2018
src/main/minio.js
Outdated
| @@ -538,13 +538,14 @@ export class Client { | |||
| var headers = {} | |||
| // virtual-host-style request but signed with region 'us-east-1' | |||
kannappanr
reviewed
Mar 6, 2018
src/main/minio.js
Outdated
| if (e && e.name === 'AuthorizationHeaderMalformed') { | ||
| if (!region) region = 'us-east-1' | ||
| this.makeRequest({method, bucketName, headers}, payload, 200, region, false, (e) => { | ||
| if (e && e.code === 'AuthorizationHeaderMalformed') { | ||
| // if the bucket already exists in non-standard location we try again |
There was a problem hiding this comment.
Should this comment also be updated?
Remove AuthorizationHeaderMalformed fallback as S3 returns the right error
krishnasrinivas
force-pushed
the
makebucket-sign-region
branch
from
bbb5bc7 to
42578f8
Compare
harshavardhana
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.