Adds spec for getObject on missing key #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| client.getObject(bucketName, 'an-object-that-does-not-exist', (e, stream) => { | ||
| if (e) { | ||
| if (e.code === 'NoSuchKey') return done(); | ||
| console.error('Unexpected error code', e.code, typeof e.code, e); |
There was a problem hiding this comment.
return done(new Error("expected NoSuchKey error")
| }); | ||
| stream.on('end', () => { | ||
| done(new Error('Got end event on non-existent object')); | ||
| }) |
There was a problem hiding this comment.
+ stream.on('readable', () => {
+ done(new Error('Got readable event on non-existent object'));
+ });
+ stream.on('data', data => {
+ done(new Error('Got data event on non-existent object'));
+ });
+ stream.on('error', () => {
+ done(new Error('Got error event on non-existent object (but falsy error argument)'));
+ });
+ stream.on('end', () => {
+ done(new Error('Got end event on non-existent object'));
+ })
replace this with:
return done(new Error("object should not exist"))
|
@solsson Please remove the extra semicolon at line 367. |
krishnasrinivas
approved these changes
Apr 6, 2018
kannappanr
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find a spec for this. I think it's common to have to handle this error in a specific way.