Support for setRequestOptions #685
Conversation
| if (!isObject(options)) { | ||
| throw new TypeError('request options should be of type "object"') | ||
| } | ||
| this.reqOptions = _.pick(options, ['agent', 'ca', 'cert', 'ciphers', 'clientCertEngine', 'crl', 'dhparam', 'ecdhCurve', 'honorCipherOrder', 'key', 'passphrase', 'pfx', 'rejectUnauthorized', 'secureOptions', 'secureProtocol', 'servername', 'sessionIdContext']) |
There was a problem hiding this comment.
I am not sure why this is needed, in addition this list needs to be updated when nodejs tls API gets updated.
There was a problem hiding this comment.
This is needed for developers to pass custom agent or TLS related configs (custom certs) Have a look at the discussion on #677
There was a problem hiding this comment.
This is needed for developers to pass custom agent or TLS related configs (custom certs) Have a look at the discussion on #677
I mean why this is not only this.reqOptions = options, why are we picking specific fields ?
There was a problem hiding this comment.
because we dont want to let the user provide option.host option.headers etc even by mistake which cause minio-js calls to fail
|
@krishnasrinivas, it looks like this PR conflicts with this #686, can you take a look ? |
once this PR is merged the other PR will not show the conflict @vadmeste |
Support for setting http request options (things like http agent, TLS related configs)