Adds 3 missing constructor parameters. #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
May 15, 2018
docs/API.md
Outdated
| |`accessKey` | _string_ |accessKey is like user-id that uniquely identifies your account. | | ||
| |`secretKey` | _string_ | secretKey is the password to your account.| | ||
| |`region` | _string_ |Set this value to override region cache. (Optional)| | ||
| |`transport` | _string_ |Set this value to to pass in a custom transport. (Optional)| |
There was a problem hiding this comment.
s/to to/to (only single to is okay)
| |`secure` | _bool_ |If set to true, https is used instead of http. Default is true. | | ||
| |`region` | _string_ |Set this value to override auto bucket region discovery. (Optional)| | ||
| |`accessKey` | _string_ |accessKey is like user-id that uniquely identifies your account. | |
There was a problem hiding this comment.
Only one PR is needed #696 is doing the same thing
Closed
smouli
force-pushed
the
missingConstParams
branch
from
8990ca0 to
48c3fd3
Compare
smouli
force-pushed
the
missingConstParams
branch
from
48c3fd3 to
6237e99
Compare
krishnasrinivas
approved these changes
May 16, 2018
harshavardhana
approved these changes
May 16, 2018
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #684