Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersionId support in listObjects API #903

Merged
merged 7 commits into from
Mar 4, 2021

Conversation

prakashsvmx
Copy link
Member

Version Id support in listObjects API

@prakashsvmx prakashsvmx force-pushed the versioned-list-object branch 2 times, most recently from 5a5ebc0 to f69303d Compare February 17, 2021 07:46
@prakashsvmx prakashsvmx self-assigned this Feb 17, 2021
@prakashsvmx prakashsvmx force-pushed the versioned-list-object branch from f69303d to 98c2637 Compare February 18, 2021 06:51
@prakashsvmx prakashsvmx marked this pull request as ready for review February 18, 2021 06:56
Copy link
Contributor

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following part of the code is also broken, between lines 435-441. You need to fix it.

Obviously, the fix should be implemented for both versioned and non-versioned cases; i.e.

listBucketResult

and

listVersionsResult

  if (xmlobj.CommonPrefixes) {
    toArray(xmlobj.CommonPrefixes).forEach(commonPrefix => {
      var prefix = toArray(commonPrefix.Prefix)[0]
      var size = 0
      result.objects.push({prefix, size})
    })
  }

src/main/xml-parsers.js Outdated Show resolved Hide resolved
src/main/xml-parsers.js Outdated Show resolved Hide resolved
src/main/minio.js Show resolved Hide resolved
@prakashsvmx prakashsvmx force-pushed the versioned-list-object branch from de13f3f to 175f745 Compare February 25, 2021 04:50
@prakashsvmx prakashsvmx force-pushed the versioned-list-object branch from 175f745 to ea35870 Compare February 25, 2021 04:51
examples/list-objects.js Outdated Show resolved Hide resolved
src/main/minio.js Show resolved Hide resolved
src/main/xml-parsers.js Outdated Show resolved Hide resolved
ebozduman
ebozduman previously approved these changes Feb 26, 2021
Copy link
Contributor

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kanagarajkm
kanagarajkm previously approved these changes Feb 26, 2021
@prakashsvmx prakashsvmx dismissed stale reviews from kanagarajkm and ebozduman via b20997b March 1, 2021 04:47
@prakashsvmx
Copy link
Member Author

@kannappanr @ebozduman I have added isDeleteMarker flag similar to other sdk's . PTAL.

@prakashsvmx prakashsvmx force-pushed the versioned-list-object branch from b20997b to 0f49c8f Compare March 1, 2021 04:59
Copy link
Contributor

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit bb7c645 into minio:master Mar 4, 2021
@prakashsvmx prakashsvmx deleted the versioned-list-object branch February 10, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants