Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture network device info in health report #18381

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

anjalshireesh
Copy link
Contributor

@anjalshireesh anjalshireesh commented Nov 2, 2023

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Capture network device information and return in the healthinfo api

Motivation and Context

Useful for debugging, can be used to add check(s) related to network device driver and revision.

How to test this PR?

  • Generate health report (mc support diag <alias> --airgap)
  • Verify that there is a new node for each server under sys -> netinfo

Note: on single-server setups where loopback device gets used, there will be an error operation not supported

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit f6e581c into minio:master Nov 2, 2023
19 checks passed
@anjalshireesh anjalshireesh deleted the health branch November 3, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants