-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ingresses to tenant helm chart #1153
Conversation
Tested by deploying with auto TLS enabled in MinIO -
API check
|
We currently have version 4.4.22 in progress with changes for helm test already, let's get this version merged then I will understand and test this requested change. Thank you @dnskr for this PR! 👍 |
6da7106
to
e18b00b
Compare
The PR has been rebased onto Release v4.4.22 commit in master. |
f5c8d0c
to
4aa3a05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me:
- All tests are passing (not affected)
- Tenant can be deployed via Helm (Either kind or minikube)
- It is a nice addition to have load balancer (ingress controller)
@cniackz Could |
Hello @dnskr yes, I have removed the |
PR implements #585 with some additional improvements.
Implementation notes:
API Ingress
andConsole Ingress
Testing notes:
Tested locally on minikube
Tested by deploying without TLS
API check
Console check