Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingresses to tenant helm chart #1153

Merged
merged 2 commits into from
Jun 4, 2022

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented May 27, 2022

PR implements #585 with some additional improvements.

Implementation notes:

  • Two independent Ingress objects have been added to tenant helm chart: API Ingress and Console Ingress
  • Operator Ingress has been simplified due to minimal Kubernetes version requirement
  • MinIO version has been updated in tenant helm chart
  • Fixed some value types in tenant helm chart

Testing notes:

Tested locally on minikube

$ minikube start
$ minikube addons enable ingress
$ minikube version
minikube version: v1.25.2

Tested by deploying without TLS

helm install minio-tenant tenant \
 --set tenant.pools[0].volumesPerServer=1 \
 --set tenant.certificate.requestAutoCert=false \
 --set tenant.kes.kesSecret.name="" \
 --set tenant.prometheus.diskCapacityGB="" \
 --set tenant.log.audit.diskCapacityGB="" \
 --set ingress.api.enabled=true \
 --set ingress.console.enabled=true \
 --namespace minio-tenant --create-namespace

API check

$ mc alias set minio http://minio.local minio minio123
Added `minio` successfully.
$ mc ls minio
[2022-05-26 15:44:44 CEST]     0B test/

Console check
tenant-login
tenant-console

@dnskr
Copy link
Contributor Author

dnskr commented May 27, 2022

Tested by deploying with auto TLS enabled in MinIO - tenant.certificate.requestAutoCert=true

helm install minio-tenant tenant \
 --set tenant.pools[0].volumesPerServer=1 \
 --set tenant.certificate.requestAutoCert=true \
 --set tenant.kes.kesSecret.name="" \
 --set tenant.prometheus.diskCapacityGB="" \
 --set tenant.log.audit.diskCapacityGB="" \
 --set ingress.api.enabled=true \
 --set ingress.api.annotations."nginx\.ingress\.kubernetes\.io\/backend\-protocol"=HTTPS \
 --set ingress.console.enabled=true \
 --set ingress.console.annotations."nginx\.ingress\.kubernetes\.io\/backend\-protocol"=HTTPS \
 --namespace minio-tenant --create-namespace

API check

$ mc alias set minio http://minio.local minio minio123
Added `minio` successfully.
$ mc ls minio
[2022-05-27 20:01:57 CEST]     0B test/

Console check
tenant-login-https
tenant-console-https

@cniackz cniackz requested review from harshavardhana and Alevsk May 27, 2022 19:11
@cniackz cniackz self-assigned this May 27, 2022
@cniackz cniackz requested a review from dvaldivia May 27, 2022 19:11
@cniackz
Copy link
Contributor

cniackz commented May 27, 2022

We currently have version 4.4.22 in progress with changes for helm test already, let's get this version merged then I will understand and test this requested change. Thank you @dnskr for this PR! 👍

@cniackz cniackz added the wip label May 27, 2022
@dnskr dnskr force-pushed the add_ingress_for_tenant branch from 6da7106 to e18b00b Compare May 27, 2022 23:20
@dnskr
Copy link
Contributor Author

dnskr commented May 27, 2022

The PR has been rebased onto Release v4.4.22 commit in master.

@harshavardhana harshavardhana requested a review from cniackz May 28, 2022 06:15
@cniackz
Copy link
Contributor

cniackz commented May 30, 2022

Tested manually and tenant can be deployed:

Screen Shot 2022-05-30 at 2 22 27 PM

@cniackz cniackz force-pushed the add_ingress_for_tenant branch from f5c8d0c to 4aa3a05 Compare May 30, 2022 18:24
Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me:

  1. All tests are passing (not affected)
  2. Tenant can be deployed via Helm (Either kind or minikube)
  3. It is a nice addition to have load balancer (ingress controller)

@dnskr
Copy link
Contributor Author

dnskr commented May 31, 2022

@cniackz Could wip label be removed?

@cniackz
Copy link
Contributor

cniackz commented May 31, 2022

Hello @dnskr yes, I have removed the wip label 👍 and added more people to review this PR.

@cniackz cniackz merged commit 46acf21 into minio:master Jun 4, 2022
@dnskr dnskr mentioned this pull request Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants