Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable KES for default tenant deployments using Helm #1157

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Jun 3, 2022

Documentation in: https://github.com/minio/operator/tree/master/helm/operator
is not working because deploying a tenant via helm via:

helm install --namespace tenant-ns \
  --create-namespace tenant minio/tenant

will try to enable KES on the tenant by default, the tenant will never
run because there is no VAULT/KMS configured on the cluster

Signed-off-by: Lenin Alevski [email protected]

Documentation in: https://github.com/minio/operator/tree/master/helm/operator
is not working because deploying a tenant via helm via:

```
helm install --namespace tenant-ns \
  --create-namespace tenant minio/tenant
```

will try to enable KES on the tenant by default, the tenant will never
run because there is no VAULT/KMS configured on the cluster

Signed-off-by: Lenin Alevski <[email protected]>
@Alevsk Alevsk requested review from cniackz and dvaldivia June 3, 2022 22:47
@Alevsk Alevsk self-assigned this Jun 3, 2022
@Alevsk Alevsk requested a review from harshavardhana June 3, 2022 22:47
@cniackz
Copy link
Contributor

cniackz commented Jun 3, 2022

I think this is going to break the test that is trying to remove KES with yq command, but let's see how it runs.

Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as long as no test is broken, if any I will be updating the test but I think this is a good idea since no Vault is being deployed anyway.

@cniackz cniackz merged commit 1ee9e55 into minio:master Jun 3, 2022
@Alevsk Alevsk deleted the disable-kes-helm-example branch June 3, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants