Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinIO Job CRD #1883

Merged
merged 6 commits into from
Jan 19, 2024
Merged

MinIO Job CRD #1883

merged 6 commits into from
Jan 19, 2024

Conversation

pjuarezd
Copy link
Member

Initial stubs and generated clients

@pjuarezd pjuarezd self-assigned this Nov 21, 2023
@pjuarezd pjuarezd requested a review from dvaldivia November 21, 2023 23:42
@dvaldivia dvaldivia changed the title Minio Job CRD MinIO Job CRD Nov 22, 2023
dvaldivia
dvaldivia previously requested changes Nov 22, 2023
View reviewed changes
pkg/apis/job.min.io/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/job.min.io/v1alpha1/types.go Show resolved Hide resolved
pkg/apis/job.min.io/v1alpha1/types.go Outdated Show resolved Hide resolved
@cniackz cniackz mentioned this pull request Jan 19, 2024
Closed
@cniackz cniackz requested review from cniackz and dvaldivia January 19, 2024 20:24
@cniackz cniackz dismissed dvaldivia’s stale review January 19, 2024 20:25

Changes were performed.

cniackz
cniackz approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @pjuarezd for this great Job!. I have reviewed and approved the change!.

@harshavardhana
Copy link
Member

Thank you very much @pjuarezd for this great Job!. I have reviewed and approved the change!.

Great Job on Job CRD.

harshavardhana
harshavardhana reviewed Jan 19, 2024
View reviewed changes
pkg/apis/job.min.io/v1alpha1/register.go
@@ -0,0 +1,57 @@
// Copyright (C) 2022, MinIO, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright (C) 2022, MinIO, Inc.
// Copyright (C) 2024, MinIO, Inc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need an update but can be done in another PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

@harshavardhana harshavardhana merged commit ed454ec into minio:master Jan 19, 2024
25 checks passed
@pjuarezd pjuarezd deleted the minio-job-crd branch January 19, 2024 21:52
@cniackz cniackz mentioned this pull request Jan 25, 2024
Merged
@pjuarezd pjuarezd mentioned this pull request Feb 6, 2024
Closed
@cniackz cniackz mentioned this pull request Feb 28, 2024
Merged
@allanrogerr allanrogerr mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@cniackz cniackz cniackz approved these changes

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@kanagarajkm kanagarajkm Awaiting requested review from kanagarajkm

@allanrogerr allanrogerr Awaiting requested review from allanrogerr

@jiuker jiuker Awaiting requested review from jiuker

@cesnietor cesnietor Awaiting requested review from cesnietor

@reivaj05 reivaj05 Awaiting requested review from reivaj05

Assignees

@pjuarezd pjuarezd

Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pjuarezd @harshavardhana @cniackz @dvaldivia