-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: resize pvc #1904
feat: resize pvc #1904
Conversation
Please add few verification steps. I edited tenant and added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Remove the debug prints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this is good, what is preventing Operator from increase infinite times the Storage?
CRD's and resources are declarative ways to ask what
is expected, the additionalStorage
field seems a procedural one.
ie, declarative is: Give me a 10GB PV
, this other seems procedural Give me 10GB PV, then add other 5GB
.
I think this should be revaluated @jiuker, can the PV's be resized?, ie: I know DirectPV can Expand Volume, I think that is what we should be suggesting to users instead of workaround it in Operator.
The intention here is simply to execute a command similar to expanding a PVC without causing the STS to restart. Many STS scaling operations typically result in pod restarts. Alternatively, we could use a MinioJob to accomplish this task. If this is possible, let's close this PR. @pjuarezd |
fix #1780