Fix namespace reference in Helm chart NOTES.txt #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change: Fix an issue in the NOTES.txt file of the Helm chart
Issue: While deploying the MinIO Operator using Helm, the command suggested in the NOTES.txt file was incorrect. It instructs users to retrieve a Secret in the "minio-operator" namespace, while the Secret is actually located in the namespace specified by the user.
Cause: In the NOTES.txt file, the namespace was hardcoded as "minio-operator".
Solution: I changed the hardcoded "minio-operator" to
{{ .Release.Namespace }}. This way, when Helm deploys the chart, it will replace the placeholder with the actual namespace specified by the user.I've attached the following screenshot to highlight the differences before and after the change.