bugfix: upgrades not running #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pjuarezd <[email protected]>
jiuker
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past we used to run all upgrades when the
.status.syncVersionfield was empty, after change introduced on #1512 we are conscidering this field being empty as an indicator that the tenant is "brand new".6701b4f#diff-1657476cde2d3b4184231b8d4ce3cb4db7615db642cf329dcb314db0ce190fe6R66
That comes with a problem: no upgrade ever will run on tenants created after v5.0.0 was released, so if we publish a new Upgrade, it will not run, ever.
This fix approach is to set
.status.syncVersion(when empty) with the latest published upgrade, right now "v5.0.0" so that future upgrades can actually run