Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wait tenant be green to do command #2012

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Mar 4, 2024

feat: wait tenant be green to do command

How to test:
Deploy tenant and

apiVersion: job.min.io/v1alpha1
kind: MinIOJob
metadata:
  name: minio-test-job
  namespace: default
spec:
  serviceAccountName: minio
  tenant:
    name: mytest-minio
    namespace: default
  commands:
    - name: create-minio
      op: make-bucket
      args:
        name: memes
      dependsOn: []
  1. When tenant have gone (or ref a unknown tenant). MinIOJob should have a Error status.
  2. When tenant have been green. Operator should print will do somthing next .

@jiuker jiuker requested review from pjuarezd, cniackz, dvaldivia and shtripat and removed request for pjuarezd March 4, 2024 09:55
@jiuker jiuker changed the title feat: wait tenant to do command feat: wait tenant be green to do command Mar 4, 2024
@shtripat
Copy link
Contributor

shtripat commented Mar 4, 2024

Is there any specific scenario to be verified or just sanity test is good enough for tenant to come online?

@jiuker jiuker requested a review from harshavardhana March 5, 2024 02:28
shtripat
shtripat previously approved these changes Mar 5, 2024
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. a minor one

pkg/controller/job-controller.go Show resolved Hide resolved
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified.

Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Jiuker

@cniackz cniackz merged commit 5fac040 into minio:master Mar 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants