Allow using a custom secret name #2034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
previously approved these changes
Mar 15, 2024
shtripat
previously approved these changes
Mar 15, 2024
ramondeklein
dismissed stale reviews from shtripat and harshavardhana
via
98c6380
ramondeklein
force-pushed
the
master
branch
2 times, most recently
from
98c6380 to
ee2b4d0
Compare
|
I have added the |
|
Closing this in favor of #2032, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Helm chart to create a new tenant allows to specify
.secrets.existingSecret.name(if you already have a secret) or.secrets.name(if you want to create a new secret by the Helm chart). When setting the secret's name, the tenant won't initialize properly and the operator shows the following error message:After some digging it seems that you also need to set the
.tenant.configuration.namevalue to the secret name to make it work. This isn't obvious from the documentation.Because these values should always be identical, it doesn't make much sense to use the
.tenant.configuration.namevalue in the Helm chart. This PR sets the tenant configuration to the (existing) secret name, so you only need to set one value. Because the Helm chart won't create a new secret when.secrets.existingSecret.nameis set, this value has precedence above.secrets.name.