Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no default label when nothing set for console service #2049

Merged

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Mar 27, 2024

no default label when nothing set for console service

fix: no default label when nothing set for console service
@jiuker jiuker linked an issue Mar 27, 2024 that may be closed by this pull request
@cniackz
Copy link
Contributor

cniackz commented Apr 16, 2024

@jiuker, could you please elaborate on why this is necessary? Perhaps you could provide a more meaningful message or description?

@jiuker
Copy link
Contributor Author

jiuker commented Apr 17, 2024

fix #2047 If we set t.Spec.ServiceMetadata.ConsoleServiceLabels, the service will have the default labels and the customs's labels. But If we do not set that , no labels to the service. @cniackz

@harshavardhana harshavardhana merged commit aa1337c into minio:master Apr 17, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to add defualt label to console
4 participants