allow arbitrary labels to be set on operator and console resources #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramondeklein
force-pushed
the
master
branch
6 times, most recently
from
f8e6334 to
d97dd66
Compare
|
@ChrisVanLawAtFanatics I have made some changes (and cleaned up a little). I think your functionality is still supported, but it's a bit cleaner (IMHO). |
ramondeklein
approved these changes
Apr 16, 2024
|
@cesnietor Do you know what could be causing the test-decommision job to fail? It looks like it properly created all resources and something fails during teardown. UPDATE: Second run went fine. Not sure what's going on... |
|
Thanks @ramondeklein! I appreciate your help on this and taking a look at the PR so quickly! |
cniackz
approved these changes
Apr 20, 2024
|
@ramondeklein and @pjuarezd do you think we can merge it? or more changes are required? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow arbitrary labels to be set for console and operator resources via values. This allows better management of created resources as well as integration with other tools e.g. by setting tags for datadog.
operator.additionalLabelsadded to values for operator-specific labelsconsole.additionalLabelsadded to values for console-specific labels