label is vague and create conflicts, renaming to minio-operator

[pjuarezd]

Fix bug:

for: "/home/runner/work/operator/operator/testing/../testing/dev": Deployment.apps "minio-operator" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/name":"operator", "name":"minio-operator"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

[cniackz]

Tenant Tests On Kind / test-tenant-upgrade (1.21.x, ubuntu-latest) (pull_request) will be fixed in #2087

[ramondeklein]

I checked the repo and we use app.kubernetes.io/name: operator in all bundles, certififed-operators too. I also see app.kubernetes.io/name: operator in some other places in the resources folder and checks for app.kubernetes.io/name=operator in testing/common.sh, so we may want to take a second look at this...

[pjuarezd]

I checked the repo and we use app.kubernetes.io/name: operator in all bundles, certififed-operators too. I also see app.kubernetes.io/name: operator in some other places in the resources folder and checks for app.kubernetes.io/name=operator in testing/common.sh, so we may want to take a second look at this...

Yeah, commonly a kubernetes cluster would have many operators installed and the name (I think) is not a good indicative of what the "app" does if we just called the app "operator" altrough I think we should call it "minio-operator" probably should rename it on all the other places too in this PR.

[ravindk89]

I checked the repo and we use app.kubernetes.io/name: operator in all bundles, certififed-operators too. I also see app.kubernetes.io/name: operator in some other places in the resources folder and checks for app.kubernetes.io/name=operator in testing/common.sh, so we may want to take a second look at this...

Yeah, commonly a kubernetes cluster would have many operators installed and the name (I think) is not a good indicative of what the "app" does if we just called the app "operator" altrough I think we should call it "minio-operator" probably should rename it on all the other places too in this PR.

We're waiting on that work to complete correct?

[pjuarezd]

I checked the repo and we use app.kubernetes.io/name: operator in all bundles, certififed-operators too. I also see app.kubernetes.io/name: operator in some other places in the resources folder and checks for app.kubernetes.io/name=operator in testing/common.sh, so we may want to take a second look at this...

Yeah, commonly a kubernetes cluster would have many operators installed and the name (I think) is not a good indicative of what the "app" does if we just called the app "operator" altrough I think we should call it "minio-operator" probably should rename it on all the other places too in this PR.

We're waiting on that work to complete correct?

yeap, I think I need to update helm chart and tests, WIP

[harshavardhana]

Tenant Tests On Kind / test-tenant-upgrade (1.21.x, ubuntu-latest) (pull_request) will be fixed in #2087

This test is still failing.

[pjuarezd]

I checked the repo and we use app.kubernetes.io/name: operator in all bundles, certififed-operators too. I also see app.kubernetes.io/name: operator in some other places in the resources folder and checks for app.kubernetes.io/name=operator in testing/common.sh, so we may want to take a second look at this...

Looked again, changing the identifier from operator to minio-operator is a mayor change in Helm chart, we want to be cautious with this one since could break helm chart upgrades, closing this for now