Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misjudge certificate expiring #2127

Merged

Conversation

usernameisnull
Copy link
Contributor

I don't know the origin menaing of this, may be a bug.

Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely solves an issue, but code can be simplified.

pkg/controller/custom.go Outdated Show resolved Hide resolved
pkg/controller/custom.go Outdated Show resolved Hide resolved
pkg/controller/custom.go Outdated Show resolved Hide resolved
@ramondeklein ramondeklein self-requested a review May 21, 2024 17:47
@usernameisnull usernameisnull force-pushed the fix/misjudge-certificate-expiring branch from a53c601 to 8948db3 Compare May 21, 2024 17:49
@usernameisnull usernameisnull force-pushed the fix/misjudge-certificate-expiring branch from 8948db3 to e48f070 Compare May 21, 2024 18:02
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allanrogerr
Copy link
Contributor

@ramondeklein ramondeklein merged commit 1c2fa4f into minio:master May 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants