Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve sa/role/rolebind check/update #2159

Merged

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Jun 12, 2024

feat: improve sa/the role/rolebind check
fix case:
If user used a very old sa/role/rolebind to start minio.
We only check the name exists.
Now we check the items as well.

How to test:
1.Deploy tenant myminio.
2.Remove the role myminio-role rules:

  - verbs:
      - get
      - list
      - watch
    apiGroups:
      - minio.min.io
    resources:
      - tenants
  1. Restart minio pod. We can see sidecar that will print errrors for it can't watch the tenant change.
  2. But our operator show everything is fine.

This pr is ensure that when it got deleted, we set what we execepted items back

feat: improve sa/the role/rolebind check
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, verified

@pjuarezd pjuarezd merged commit 6a90c45 into minio:master Jun 12, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants