Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document default MC image for MinIOJob CRD #2187

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

pjuarezd
Copy link
Member

  • Document default MC image in the adocs
  • Add release script section to set a defined mc image instead of 'latest'

When we create the release PR, the default latest mc image tag will be replaced by the date format of the latest mc relaesed image

RELEASE=v6.0.0 make release

Add release script section to set a defined mc image instead of 'latest'

Signed-off-by: pjuarezd <[email protected]>
@pjuarezd pjuarezd self-assigned this Jun 28, 2024
@pjuarezd pjuarezd changed the title Document default MC image Document default MC image for MinIOJob CRD Jun 28, 2024
@pjuarezd pjuarezd mentioned this pull request Jun 28, 2024
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like that we now have a fixed version. Makes it more predictable.

@pjuarezd
Copy link
Member Author

Failing test is because of govulncheck found https://pkg.go.dev/vuln/GO-2024-2527

  1. There is no fix yet for this package
  2. govulncheck do not support to silence or ignore a vulnerability, per the docs on limitations

There is no support for silencing vulnerability findings. See https://go.dev/issue/61211 for updates.

Evaluationg if we should we disable the govulncheck github action? or just ignore the error and merge for the forsee times until the vuln is fixed.
cc @harshavardhana @dvaldivia

@pjuarezd pjuarezd merged commit 24f34a0 into minio:master Jun 29, 2024
29 of 31 checks passed
@pjuarezd pjuarezd deleted the document-mc-image branch June 29, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants