Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PVC expansion logic for MinIO Operator #2196

Merged
merged 1 commit into from
Jul 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/controller/main-controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -1310,6 +1310,12 @@ func (c *Controller) syncHandler(key string) (Result, error) {
}
}

// Handle PVC expansion
err = ExpandPVCs(ctx, c.kubeClientSet, tenant, namespace)
if err != nil {
return WrapResult(Result{}, err)
}

if tenant.HasPrometheusOperatorEnabled() {
err := c.checkAndCreatePrometheusAddlConfig(ctx, tenant, string(tenantConfiguration["accesskey"]), string(tenantConfiguration["secretkey"]))
if err != nil {
Expand Down
44 changes: 44 additions & 0 deletions pkg/controller/pvc.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
package controller

import (
"context"
"fmt"

miniov2 "github.com/minio/operator/pkg/apis/minio.min.io/v2"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes"
"k8s.io/klog/v2"
)

// ExpandPVCs expands the PVCs for a given tenant
func ExpandPVCs(ctx context.Context, kubeClientSet kubernetes.Interface, tenant *miniov2.Tenant, namespace string) error {
uOpts := metav1.UpdateOptions{}

for _, pool := range tenant.Spec.Pools {
opts := metav1.ListOptions{
LabelSelector: fmt.Sprintf("%s=%s,%s=%s", miniov2.TenantLabel, tenant.Name, miniov2.PoolLabel, pool.Name),
}
pvcList, err := kubeClientSet.CoreV1().PersistentVolumeClaims(namespace).List(ctx, opts)
if err != nil {
return err
}

for _, pvc := range pvcList.Items {
if pool.VolumeClaimTemplate != nil {
requestedStorage := pool.VolumeClaimTemplate.Spec.Resources.Requests[corev1.ResourceStorage]
currentStorage := pvc.Spec.Resources.Requests[corev1.ResourceStorage]
if requestedStorage.Cmp(currentStorage) > 0 {
pvc.Spec.Resources.Requests[corev1.ResourceStorage] = requestedStorage
_, err = kubeClientSet.CoreV1().PersistentVolumeClaims(namespace).Update(ctx, &pvc, uOpts)
if err != nil {
return err
}
klog.Infof("Expanded PVC %s from %s to %s", pvc.Name, currentStorage.String(), requestedStorage.String())
}
}
}
}

return nil
}
72 changes: 72 additions & 0 deletions pkg/controller/pvc_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
package controller

import (
"context"
"testing"

miniov2 "github.com/minio/operator/pkg/apis/minio.min.io/v2"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes/fake"
)

func TestExpandPVCs(t *testing.T) {
ctx := context.Background()

tenant := &miniov2.Tenant{
ObjectMeta: metav1.ObjectMeta{
Name: "test-tenant",
},
Spec: miniov2.TenantSpec{
Pools: []miniov2.Pool{
{
Name: "pool1",
VolumeClaimTemplate: &corev1.PersistentVolumeClaim{
Spec: corev1.PersistentVolumeClaimSpec{
Resources: corev1.VolumeResourceRequirements{
Requests: corev1.ResourceList{
corev1.ResourceStorage: resource.MustParse("2Gi"),
},
},
},
},
},
},
},
}

pvc := &corev1.PersistentVolumeClaim{
ObjectMeta: metav1.ObjectMeta{
Name: "test-pvc",
Namespace: "test-namespace",
Labels: map[string]string{
miniov2.TenantLabel: tenant.Name,
miniov2.PoolLabel: "pool1",
},
},
Spec: corev1.PersistentVolumeClaimSpec{
Resources: corev1.VolumeResourceRequirements{
Requests: corev1.ResourceList{
corev1.ResourceStorage: resource.MustParse("1Gi"),
},
},
},
}

kubeClient := fake.NewSimpleClientset(pvc)

err := ExpandPVCs(ctx, kubeClient, tenant, "test-namespace")
if err != nil {
t.Fatalf("ExpandPVCs failed: %v", err)
}

updatedPVC, err := kubeClient.CoreV1().PersistentVolumeClaims("test-namespace").Get(ctx, "test-pvc", metav1.GetOptions{})
if err != nil {
t.Fatalf("Failed to get PVC: %v", err)
}

if updatedPVC.Spec.Resources.Requests[corev1.ResourceStorage] != resource.MustParse("2Gi") {
t.Errorf("Expected PVC storage to be 2Gi, but got %v", updatedPVC.Spec.Resources.Requests[corev1.ResourceStorage])
}
}
Loading