Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have Sidecar reuse the same HTTP client and discard request body #2213

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Have Sidecar reuse the same HTTP client and discard request body #2213

merged 2 commits into from
Jul 16, 2024

Conversation

dvaldivia
Copy link
Collaborator

No description provided.

@dvaldivia dvaldivia self-assigned this Jul 16, 2024
@dvaldivia dvaldivia requested a review from shtripat July 16, 2024 06:15
shtripat
shtripat previously approved these changes Jul 16, 2024
View reviewed changes
ramondeklein
ramondeklein previously approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Didn't know that conection wasn't re-used when body wasn't read. Not sure if this is true when using HTTP/2.

@pjuarezd pjuarezd dismissed stale reviews from ramondeklein and shtripat via 1399868 July 16, 2024 17:24
@harshavardhana
Copy link
Member

LGTM. Didn't know that conection wasn't re-used when body wasn't read. Not sure if this is true when using HTTP/2.

yeah this is Go thing @ramondeklein

@harshavardhana harshavardhana merged commit 3e8321f into minio:master Jul 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjuarezd pjuarezd pjuarezd approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@shtripat shtripat shtripat left review comments

@ramondeklein ramondeklein ramondeklein left review comments

@cniackz cniackz Awaiting requested review from cniackz

@cesnietor cesnietor Awaiting requested review from cesnietor

@allanrogerr allanrogerr Awaiting requested review from allanrogerr

@bayasdev bayasdev Awaiting requested review from bayasdev

Assignees

@dvaldivia dvaldivia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dvaldivia @harshavardhana @pjuarezd @ramondeklein @shtripat