Working features in browser #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button is only shown when hovering, this solution works in poltergeist headless _and_ chome webdriver
slow rendering after a logout was causing a flickering test when run in browser
jsugarman
approved these changes
Aug 1, 2018
| @@ -40,7 +40,8 @@ | |||
|
|
|||
| Then(/^I select the first search result$/) do | |||
| sleep Capybara.default_max_wait_time | |||
| @claim_form_page.offence_results.first.select_button(visible: false).trigger('click') | |||
| find(:xpath, '//*[@id="offence-list"]/div[3]/div').hover | |||
There was a problem hiding this comment.
As discussed, can we just put a # TODO: get working in site-prism on this.
There was a problem hiding this comment.
I've added an issue, #2454
|
🏆 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
@lostie implemented chrome based testing as part of #2225
Why
Not all tests would run successfully, some because of the use of
.trigger('click')some because of hidden or hover elements that poltergeist ignores.How
Find all uses of
.trigger('click')and replace with.click, this is honoured by poltergeist and chrome-webdriverIdentified and rectified all other failures.
TODO (wip)