Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctskf 690 cccd set up access to maat api #6611

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

Katy600
Copy link
Contributor

@Katy600 Katy600 commented Mar 12, 2024

What

This is a combination of Maat integration which was a test ticket for implementing maat combined with CCCD - Set up access to MAAT API from deployed environments which was to get access to Access to the Maat Api with in cognito and create ab interface for making requests to the API.

Ticket

CCCD - Set up access to MAAT API from deployed environments

Why

This is a user centred ticket and is intended to automate something that caseworkers currently have to manually input. This will speed up the process as well as remove potential human error.

How

Auto filling using Maat API

@Katy600 Katy600 force-pushed the CTSKF-690CCCD---Set-up-access-to-MAAT-API branch 2 times, most recently from 482159e to 44a36fc Compare March 22, 2024 12:17
@Katy600 Katy600 force-pushed the CTSKF-690CCCD---Set-up-access-to-MAAT-API branch from 3cb9fa3 to 45c3e88 Compare March 28, 2024 14:31
@jrmhaig jrmhaig force-pushed the CTSKF-690CCCD---Set-up-access-to-MAAT-API branch 5 times, most recently from bf3881f to ad7132b Compare April 2, 2024 14:50
@jrmhaig jrmhaig force-pushed the CTSKF-690CCCD---Set-up-access-to-MAAT-API branch from ad7132b to 876d141 Compare April 2, 2024 14:52
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jrmhaig jrmhaig marked this pull request as ready for review April 3, 2024 08:19
@jrmhaig jrmhaig requested review from a team as code owners April 3, 2024 08:19
@@ -0,0 +1,11 @@
= govuk_table do |table|
- table.with_caption(size: 's', text: 'Details from MAAT (beta)')
Copy link

@vloruncg vloruncg Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this still be in beta once released?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not actually be displayed yet as this PR is just to get the connection code in the codebase, so that it can be used and built on. I think, however, that when we get to the point of displaying information it should be indicated that it is beta or experimental for a period of time.

Copy link

@vloruncg vloruncg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrmhaig jrmhaig merged commit 3f3c8b2 into master Apr 9, 2024
18 of 21 checks passed
@jrmhaig jrmhaig deleted the CTSKF-690CCCD---Set-up-access-to-MAAT-API branch April 9, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants