Upgrade to Rails 7.1 #7327
Draft
Upgrade to Rails 7.1 #7327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmhaig
force-pushed
the
rails_7_1
branch
4 times, most recently
from
537d87d to
5afac4c
Compare
|
jrmhaig
force-pushed
the
rails_7_1
branch
3 times, most recently
from
573a6f5 to
94d12e1
Compare
`config.load_defaults` is set to 7.0 and upgrading tasks have not been done yet
Raising for missing callback actions is a new default in Rails 7.1. Therefore a callback that is defined by an extended concern will cause a failure if the action is not defined. The `regenerate_api_key` only exists for external user admin so the callback needs to be moved from the concern to the controller.
Fix for deprecation warning: > DEPRECATION WARNING: Passing the class as positional argument is deprecated and will be removed in Rails 7.2.
The PasswordHelpers mixin is split into to parts: * PasswordHelpers contains helpers for updating user password * UserAdminHelpers includes helpers for creating new users Rails 7.1 by default raises exceptions when attempting to create callback for actions that do not exist. This caused exceptions with SuperAdminController, which does not have the `create` action for creating new users.
In Rails 7.1 the `sum` method no longer overrides `Enumerable#sum`. One change is that there is no implicit conversion of nil to integer. When a fee is cleared with `Fee::BaseFee#clear` the amount is set to nil and so claim.basic_fees.sum(&:amount) fails. It might be appropriate to change `Fee::BaseFee#clear` so that the values are set to zero instead of nil. However, this may have other side-effects.
After upgrading to Rails 7.1 there were persistent 'stack level too deep' with some partials. This was traced back to: https://github.com/rails/rails/blob/fa9cf269191c5077de1abdd1e3f934fbeaf2a5d0/activesupport/lib/active_support/core_ext/object/json.rb#L58-L66 Changing this monkey patch slightly prevents the errors. Ideally, this will be removed when a better solution is found. See: rails/rails#51626
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.load_defaultsis set to 7.0 and upgrading tasks have not been done yetWhat
Ticket
board ticket description
Why
How
TODO (wip)