Create new file names to implement changes #7862
Conversation
Katy600
force-pushed
the
CTSKF-993--Implement-Summary-Page-accessibility-improvements--attempt-2
branch
4 times, most recently
from
6f86402 to
3824dfe
Compare
Katy600
force-pushed
the
CTSKF-993--Implement-Summary-Page-accessibility-improvements--attempt-2
branch
3 times, most recently
from
78afaec to
96d93e7
Compare
Update translate files to align with new files This commit also formats the certification in a new summary card.
and amend translate file; Fix accessibility issue; Amend new evidence list partial;
Amend defendant details translate files; Fix claim details maat and date issue; Amend defendant details to display maat details; Put date on separate rows; Number each defendant; Update translation files;
Update translations in Offence detail; Fix accessibility errors
Katy600
force-pushed
the
CTSKF-993--Implement-Summary-Page-accessibility-improvements--attempt-2
branch
from
96d93e7 to
25bd3a4
Compare
Move additional fees into a partial; Move translations to reflect new partial;
Convert date to long form - warrant fees;
Tidy up main hearing date in claims table so that it displays correctly
Tidy up translation files;
reuse partial from lgfs warrant fee and rename files; Fix and tidy up translations lgfs fees section;
…headings and spacing; Add accordion panel to additional information to create consistent spacing;
Katy600
force-pushed
the
CTSKF-993--Implement-Summary-Page-accessibility-improvements--attempt-2
branch
from
25bd3a4 to
d42e424
Compare
|
| %p.govuk-body | ||
| = t('.no_defendant') | ||
|
|
||
| - unless claim.fixed_fee_case? |
There was a problem hiding this comment.
We have this conditional here, but we also have the same check at the top of shared/offence_details/_new_summary. Could one of them be removed?
| @@ -501,3 +500,94 @@ form { | |||
| .error { | |||
| color: $govuk-error-colour; | |||
| } | |||
|
|
|||
| .no-bullets-item { | |||
There was a problem hiding this comment.
There's quite a lot of custom CSS being added here. If it's all necessary, is it possible to break it down into individual files for each component rather than adding it all to this file? For example we already have a file app/webpack/stylesheets/components/_table.scss which you could add the table styling to, and app/webpack/stylesheets/components/_card.scss which you could add the summary card styling to.
The other styling might fit into other similar files, or you could create new ones if needed.
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Nitpicky, but could these blank lines be deleted? I've noticed similar blank lines at the end of a few other files, it might be better if they could all be tidied up a bit (sorry!)
| .govuk-summary-card__title-wrapper | ||
| %h2.govuk-summary-card__title= t('.existing_evidence') | ||
| .govuk-summary-card__content | ||
| %dl.govuk-summary-list |
There was a problem hiding this comment.
There are some summary_list helper methods in lib/govuk_component/summary_list_helpers.rb which might make this section a bit cleaner. There's an example of how to use it here: app/views/external_users/claims/case_details/_summary.html.haml.
Edit: actually, I can see that there are lots of places in other files here where that helper could potentially be used. Possibly it's too big a change for this PR at this point...
What
This ticket focuses on updating the CCCD case worker summary page only (other summary pages on the provider side are still waiting for designed) and implementing the gov design summary cards to display the claim information in a more readable way.
Summary cards
Ticket
CCCD - Implement Summary Page accessibility improvements (caseworker) wrap in summary cards.
Why
The CCCD summary page displays essential information but suffers from poor usability. To improve user experience and accessibility, we will implement a new design pattern developed from other projects.
Additional thoughts