Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctskf 833 250113 #8041

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Ctskf 833 250113 #8041

wants to merge 22 commits into from

Conversation

VinceChiuMOJ
Copy link
Contributor

Ticket:

https://dsdmoj.atlassian.net/browse/CTSKF-833


250113 updates:

Checked out a new branch to refine the changes did before on top of CTSKF-1002 and CTSKF-832_250106

jrmhaig and others added 21 commits December 9, 2024 11:46
Note that the moj frontend component uses POST for both create and delete.
tidied up the ability file
Added error handling for multi-file-upload.
changed font color
Fixed not showing error returned by the component
Tmp implementation of attaching documents to message
Created testing rake task on attachment duplication
update documents rake to duplicate all attachment in database.
message.rb:
Added attachments
Added duplicate_message_attachment in after_create
doocument.rake:
rake task to duplicate message attachment
fix rubocop test on coding style
fix rsepc test on message #destroy
Remove redundant checking.
added count_blob_map
refine the original changes on top of CTSKF-1002
fix typo
Refinement and comment out test for trial
1. document now attached to attachments
2. remove redundant button
@VinceChiuMOJ VinceChiuMOJ requested review from a team as code owners January 13, 2025 13:53
fix rspec and rubocop tests
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants