Remove inflection of GOVUK #8059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously inflection had been added to uppercase `GOVUK`. This causes conflicts with the govuk-components gem, which uses the format `Govuk`. To resolve the conflict and allow the use of the gem, this commit removes the inflection and updates the capitalisation of all uses of GOVUK in the ruby codebase.
|
jrmhaig
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Previously, inflection had been added to uppercase occurrences of
GOVUKin the ruby code in CCCD: #6163This causes conflicts with the
govuk-componentsgem, which uses the formatGovuk.To resolve that conflict and allow the use of the gem, this change removes the inflection and updates the capitalisation of all uses of GOVUK in the ruby codebase.