-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctskf 832 250116 #8064
Open
VinceChiuMOJ
wants to merge
12
commits into
master
Choose a base branch
from
CTSKF-832_250116
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ctskf 832 250116 #8064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
message.rb: Added attachments Added duplicate_message_attachment in after_create doocument.rake: rake task to duplicate message attachment
Remove redundant checking.
Co-authored-by: Joseph Haig <[email protected]>
added count_blob_map
refine the original changes on top of CTSKF-1002
Refinement and comment out test for trial
refine the original changes on top of CTSKF-1002
Refinement and comment out test for trial
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
https://dsdmoj.atlassian.net/browse/CTSKF-832
241006 updates:
Changed the attachment variable name to attachments (plural for multiple). New attachments (one) can be added and download afterwards. The old attachment did not work anymore. Fixed by updating the name column in active_storage_attachments.
241025 updates:
Tried to modified rspec tests to pass.
Accidentally fixed the issue for remove file link not showing for attachments.
250113 updates:
Checked out a new branch to refine the changes did before on top of CTSKF-1002
No idea why there is no change in blob count, will further investigate