Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctskf 832 250116 #8064

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Ctskf 832 250116 #8064

wants to merge 12 commits into from

Conversation

VinceChiuMOJ
Copy link
Contributor

Ticket:

https://dsdmoj.atlassian.net/browse/CTSKF-832


241006 updates:

Changed the attachment variable name to attachments (plural for multiple). New attachments (one) can be added and download afterwards. The old attachment did not work anymore. Fixed by updating the name column in active_storage_attachments.

241025 updates:

Tried to modified rspec tests to pass.
Accidentally fixed the issue for remove file link not showing for attachments.

250113 updates:

Checked out a new branch to refine the changes did before on top of CTSKF-1002

  • spec/models/message_spec.rb:
    No idea why there is no change in blob count, will further investigate

VinceChiuMOJ and others added 12 commits January 9, 2025 15:16
message.rb:
Added attachments
Added duplicate_message_attachment in after_create
doocument.rake:
rake task to duplicate message attachment
fix rubocop test on coding style
fix rsepc test on message #destroy
Remove redundant checking.
added count_blob_map
refine the original changes on top of CTSKF-1002
fix typo
Refinement and comment out test for trial
refine the original changes on top of CTSKF-1002
fix typo
Refinement and comment out test for trial
@VinceChiuMOJ VinceChiuMOJ requested review from a team as code owners January 16, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant