Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✈️ Add secrets to operator #25

Merged
merged 10 commits into from
Feb 3, 2025
Merged

✈️ Add secrets to operator #25

merged 10 commits into from
Feb 3, 2025

Conversation

jacobwoffenden
Copy link
Member

@jacobwoffenden jacobwoffenden commented Feb 3, 2025 •
edited
Loading

This pull request:

  • Enhances the workflow generator to create a list of dicts to pass into the operator. This allows a user to create secrets and have them injected directly into the containers ✨ transparently ✨

Signed-off-by: Jacob Woffenden [email protected]

@jacobwoffenden @AntFMoJ
@jhpyke @michaeljcollinsuk
teamwork makes the dream work
608721f 
Co-authored-by: Ant Fitzroy <[email protected]>
Co-authored-by: Jake H-P <[email protected]>
Co-authored-by: Michael Collins <[email protected]>
Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden jacobwoffenden self-assigned this Feb 3, 2025
@jacobwoffenden
Push to S3 on PR
35c3ae0 
Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden
Add fail-fast to s3 deploy
9472643 
Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden
snake case wins
017fa91 
Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden
Revert actions
d2a9a4c 
Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden
Remove comment
454c591 
Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden jacobwoffenden marked this pull request as ready for review February 3, 2025 16:51
@jacobwoffenden jacobwoffenden requested a review from a team as a code owner February 3, 2025 16:51
@jacobwoffenden
remove debugging
b60c3f3 
Signed-off-by: Jacob Woffenden <[email protected]>
jhpyke
jhpyke previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@jhpyke jhpyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to construct proper Secret() objects into a list ourselves 🚫
Just letting DAGFactory do it for us after we build a dict ✅

@jacobwoffenden
remove if
1c40528 
Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden
Add exit statements back
9c04996 
Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden
Update comment
fcef96f 
Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden
Copy link
Member Author

Trying to construct proper Secret() objects into a list ourselves 🚫 Just letting DAGFactory do it for us after we build a dict ✅

jhpyke
jhpyke approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@jhpyke jhpyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jacobwoffenden jacobwoffenden mentioned this pull request Feb 3, 2025
Closed
6 tasks
@jacobwoffenden jacobwoffenden merged commit bf2d705 into main Feb 3, 2025
26 checks passed
@jacobwoffenden jacobwoffenden deleted the feat/operator-secrets branch February 3, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhpyke jhpyke jhpyke approved these changes

Assignees

@jacobwoffenden jacobwoffenden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobwoffenden @jhpyke