Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate namespace by checking cloud platform repo #1453

Merged
merged 12 commits into from
Feb 7, 2025

Conversation

jamesstottmoj
Copy link
Contributor

📝 Summary

This PR relates to ministryofjustice/analytical-platform#6623

This PR validates against the cloud-platform-environments repo when entering the namespace while creating an app.

The changes in this PR are needed because it has been asked for as a FR

🔍 What should the reviewer concentrate on?

  • Feedback on specific parts of the code
  • Check side effects, if any

🧑‍💻 How should the reviewer test these changes?

  • Create a webapp
  • Enter a namespace that doesn't exist to check it errors correctly
  • Enter a namespace that does to create the app

📚 Documentation status

  • No changes to the documentation are required

jhpyke
jhpyke previously approved these changes Feb 6, 2025
Copy link

@jhpyke jhpyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be the change you want to see in the world

Copy link

@jhpyke jhpyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one very minor comment

jhpyke
jhpyke previously approved these changes Feb 6, 2025
Copy link

@jhpyke jhpyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If one has to manually run Black oneself then what is all this tech even good for

Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jamesstottmoj jamesstottmoj merged commit 635c46e into main Feb 7, 2025
11 checks passed
@jamesstottmoj jamesstottmoj deleted the feature/improve-namespace-validation branch February 7, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants