Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFP-2917 Add notification queue prod #28994

Closed
wants to merge 1 commit into from

Conversation

GaReid
Copy link
Contributor

@GaReid GaReid commented Jan 21, 2025

No description provided.

@GaReid GaReid requested a review from a team as a code owner January 21, 2025 11:04
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 14 to be created, 0 to be destroyed, 3 to be updated, 0 to be replaced and 131 unchanged.

Resources to create:

+ aws_sns_topic_subscription.hmpps_workload_notification_subscription
+ aws_sqs_queue_policy.hmpps_workload_notification_queue_policy
+ kubernetes_secret.hmpps_workload_notification_queue_dead_letter_queue
+ kubernetes_secret.hmpps_workload_notification_queue_secret
+ module.hmpps_workload_notification_dead_letter_queue.aws_iam_policy.irsa
+ module.hmpps_workload_notification_dead_letter_queue.aws_kms_alias.alias[0]
+ module.hmpps_workload_notification_dead_letter_queue.aws_kms_key.kms[0]
+ module.hmpps_workload_notification_dead_letter_queue.aws_sqs_queue.terraform_queue
+ module.hmpps_workload_notification_dead_letter_queue.random_id.id
+ module.hmpps_workload_notification_queue.aws_iam_policy.irsa
+ module.hmpps_workload_notification_queue.aws_kms_alias.alias[0]
+ module.hmpps_workload_notification_queue.aws_kms_key.kms[0]
+ module.hmpps_workload_notification_queue.aws_sqs_queue.terraform_queue
+ module.hmpps_workload_notification_queue.random_id.id

Resources to update:

! aws_iam_policy.combined_local_sqs
! module.rds-history.aws_db_parameter_group.custom_parameters
! module.rds-live.aws_db_parameter_group.custom_parameters

@FolarinOyenuga
Copy link
Contributor

@GaReid is this pr still needed?

@sambailey-moj sambailey-moj deleted the WFP-2917_set_up_notification_queue_prod branch January 30, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants